[feat] 마이핑글 - 팝업창 구현, 삭제하기 연결 #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunniiii
changed the title
Doreminwoo
approved these changes
Jan 18, 2024
| @@ -11,6 +11,5 @@ interface PingleRemoteDataSource { | |||
| teamId: Int, | |||
| participation: Boolean | |||
| ): BaseResponse<List<ResponseMyPingleDto>> | |||
|
|
|||
| suspend fun deletePingle(meetingId: Long): NullableBaseResponse<Unit?> | |||
| suspend fun deletePingleDelete(meetingId: Long): NullableBaseResponse<Unit?> | |||
There was a problem hiding this comment.
딜리트핑글딜리트... delete가 중복되는 느낌이에요 ㅠ______ㅠ
There was a problem hiding this comment.
앞에 delete는 어떤 메소드인지에 대한 프리픽스라 추가했서염
Comment on lines
+22
to
+25
| when { | ||
| pingleEntity.isOwner -> showMapDeleteModalDialogFragment(pingleEntity) | ||
| pingleEntity.isParticipating -> showMapCancelModalDialogFragment(pingleEntity) | ||
| else -> showMapJoinModalDialogFragment(pingleEntity) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20240118_203928.mp4
Uncompleted Tasks 😅
To Reviewers 📢