Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 모임장 탈퇴 스낵바 구현 #167

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Conversation

Doreminwoo
Copy link
Member

Related issue 🛠

Work Description ✏️

  • 더보기 - 탈퇴하기 시 api code 400 뜨면 모임장 탈퇴 막기

Screenshot 📸

Recording_2024-01-18-20-35-17.mp4

Uncompleted Tasks 😅

N/A

To Reviewers 📢

N/A

@jihyunniiii
Copy link
Collaborator

영상 재생 안 돼염 ㅋ

onDialogClosed = {}
).show(parentFragmentManager, WITHDRAW_MODAL)
}

companion object {
private const val FAILURE_OWNER = "400"
private const val FAILURE_OWNER_MESSAGE = "단체 개설자는 탈퇴할 수 없어요!"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스트링으로 관리해주십쇼

Copy link
Collaborator

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

머지하세영

@Doreminwoo Doreminwoo merged commit 301a4f1 into develop Jan 18, 2024
1 check passed
@Doreminwoo Doreminwoo deleted the feat-delete-snackbar branch January 18, 2024 13:34
Copy link
Collaborator

@HAJIEUN02 HAJIEUN02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생핑~!

@@ -56,20 +56,19 @@ class KakaoAuthService @Inject constructor(
fun logoutKakao(logoutListener: () -> Unit) {
UserApiClient.instance.logout { error ->
if (error != null) {
Timber.tag(TAG).e(error, "카카오 로그아웃 실패. SDK에서 토큰 삭제됨")
Timber.tag(TAG).e(error.message, "카카오 로그아웃 실패. SDK에서 토큰 삭제됨")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

팀버 좀 치네

@@ -73,7 +76,7 @@ class MoreFragment : BindingFragment<FragmentMoreBinding>(R.layout.fragment_more
}

is UiState.Error -> {
Timber.d("로그아웃 실패")
Timber.d(FAILURE_LOGOUT)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

팀버 메시지도 상수화를 하는구낭

@@ -22,8 +25,8 @@ class MoreViewModel @Inject constructor(
private val _logoutState = MutableStateFlow<UiState<Boolean>>(UiState.Empty)
val logoutState get() = _logoutState.asStateFlow()

private val _withDrawState = MutableStateFlow<UiState<Boolean>>(UiState.Empty)
val withDrawState get() = _withDrawState.asStateFlow()
private val _withDrawState = MutableSharedFlow<UiState<Boolean>>()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SharedFlow는 값이 바뀌지 않을 때도 계속 방출됐으면 해서 그러신 건가용? 그렇다면 그 이유는 먼가욤.ㅎㅅㅎ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] 모임장 탈퇴 스낵바 구현
3 participants