Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] 전체적인 viewLifecycleOwner 주입 및 상수화 리팩토링 #166

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

HAJIEUN02
Copy link
Collaborator

@HAJIEUN02 HAJIEUN02 commented Jan 18, 2024

Related issue 🛠

Work Description ✏️

  • viewLifecycleOwner로 마이그레이션
  • 상수화

Screenshot 📸

생략

Uncompleted Tasks 😅

  • 마이핑글 뷰는 아직 완성되지 않아 리팩토링하지 않았습니다!
  • plandatetime 패키지 내 파일 같은 경우에는 format 함수에 패턴을 넣는데 이걸 상수화하는게 과연 가독성에 좋을까 싶어 일단 제외했습니다!

To Reviewers 📢

https://www.notion.so/dosopt/e4267835d3d74033b6ae1c38145f6240?pvs=4
나의 viewLifecycleOwner 아티클을 보라 ㅋㅅㅋ

Copy link
Collaborator

@Dan2dani Dan2dani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🤩

Copy link
Collaborator

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마이핑글 뷰는 제가 반영했서용 ~

@HAJIEUN02 HAJIEUN02 merged commit 77e0e7d into develop Jan 18, 2024
1 check passed
@jihyunniiii jihyunniiii deleted the refactor-lifecycle branch January 28, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[refactor] 전체적인 viewLifecycleOwner 주입 및 상수화 리팩토링
3 participants