[feat] 마이핑글 뷰 & 서버통신구현 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/org/sopt/pingle/data/datasource/remote/PingleRemoteDataSource.kt # app/src/main/java/org/sopt/pingle/data/datasourceimpl/remote/PingleRemoteDataSourceImpl.kt # app/src/main/java/org/sopt/pingle/domain/repository/PingleRepository.kt
jihyunniiii
reviewed
Jan 17, 2024
Comment on lines
+3
to
+8
| enum class MyPingleType( | ||
| val boolean: Boolean | ||
| ) { | ||
| SOON(false), | ||
| DONE(true) | ||
| } |
Comment on lines
26
to
35
| ItemMyPingleBinding.inflate( | ||
| LayoutInflater.from(parent.context), | ||
| parent, | ||
| false | ||
| ), | ||
| context, | ||
| navigateToMapList, | ||
| navigateToWebViewWithChatLink, | ||
| showDeleteModalDialogFragment, | ||
| viewClickListener |
There was a problem hiding this comment.
변수가 여러개니까능,,, named argument 추가해주시면 안 될 깝쇼?
| binding.tlMyPingle.addOnTabSelectedListener(object : TabLayout.OnTabSelectedListener { | ||
| override fun onTabSelected(tab: TabLayout.Tab) { | ||
| when (tab.position) { | ||
| 0 -> { |
There was a problem hiding this comment.
이 값들도 타입에 넣어주면 더 깔끔해질 것 같네요
| class MyPingleFragment : BindingFragment<FragmentMyPingleBinding>(R.layout.fragment_my_pingle) { | ||
| private val viewModel by viewModels<MyPingleViewModel>() | ||
| private lateinit var myPingleAdapter: MyPingleAdatper | ||
| private var tabPosition = false |
Comment on lines
74
to
82
| when (tab?.position) { | ||
| 0 -> { | ||
| tabPosition = MyPingleType.SOON.boolean | ||
| viewModel.getPingleParticipationList(MyPingleType.SOON.boolean) | ||
| } | ||
|
|
||
| 1 -> { | ||
| tabPosition = MyPingleType.DONE.boolean | ||
| viewModel.getPingleParticipationList(MyPingleType.DONE.boolean) |
There was a problem hiding this comment.
onTabSelected 와 onTabReselected에 사용되는 로직이 동일하다면 함수화 시켜주는 게 좋을 것 같습니다.
| @@ -61,7 +61,7 @@ class PlanDateTimeFragment : | |||
| if (selectedLocalDate.before(todayLocalDate)) { | |||
| PingleSnackbar.makeSnackbar( | |||
| binding.root, | |||
| getString(R.string.plan_future_date_snackber), | |||
| getString(R.string.plan_future_date_snackbar), | |||
| 126 | |||
Comment on lines
+77
to
+83
| <androidx.constraintlayout.widget.Guideline | ||
| android:id="@+id/gl_top_bottom" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:orientation="horizontal" | ||
| app:layout_constraintGuide_end="@dimen/spacing20" /> | ||
|
|
Comment on lines
+291
to
+299
| android:id="@+id/layout_my_pingle_menu" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginEnd="24dp" | ||
| android:background="@color/g_10" | ||
| android:foreground="@drawable/shape_border_radius_8_stroke_1" | ||
| android:visibility="invisible" | ||
| app:layout_constraintEnd_toEndOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@id/iv_my_pingle_edit"> |
There was a problem hiding this comment.
parent에 맞추기 보다는 layout에 맞추는 게 좋을 것 같습니다. 그리고 마진 16!!
|
|
||
| <TextView | ||
| android:id="@+id/tv_my_pingle_menu_trash" | ||
| android:layout_width="wrap_content" |
Comment on lines
+179
to
+180
| <string name="my_pingle_tab_soon">\t\t\t\t\t\t\t예정된\t\t\t\t\t\t\t\t</string> | ||
| <string name="my_pingle_tab_done">\t\t\t\t\t\t참여완료\t\t\t\t\t\t</string> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Recording_2024-01-18-03-41-52.mp4
Uncompleted Tasks 😅
To Reviewers 📢
급급하게 해서 코드가 많이 더럽네요 ㅠㅠㅠㅠ 양해부탁드려요
리팩토링 때 열심히 수정해볼게요~