[fix] 자잘한 버그 수정 및 뷰 연결 #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAJIEUN02
approved these changes
Jan 17, 2024
| @@ -66,12 +68,14 @@ class AuthActivity : BindingActivity<ActivityAuthBinding>(R.layout.activity_auth | |||
|
|
|||
| private fun navigateToOnBoarding() { | |||
| Intent(this, OnBoardingActivity::class.java).apply { | |||
| flags = Intent.FLAG_ACTIVITY_CLEAR_TASK or Intent.FLAG_ACTIVITY_NEW_TASK | |||
There was a problem hiding this comment.
실행 액티비티 외 모두 제거 or 실행하는 액티비티를 새 태스크로 생성.. 그냥 단순히 이동하지 않고 이 flag를 포함해준 이유는 무엇인가요?? 찾아보니까 어느 정도는 시스템이 알아서 제어해준다고 해서요.. 흠냐
There was a problem hiding this comment.
스택 관리 때문에 추가했어요
이전에 쌓여있던 스택이 모두 지워져야 하는 경우 추가합니다
| @@ -99,7 +100,7 @@ class JoinGroupCodeActivity : | |||
| CODE_409 -> { | |||
| PingleSnackbar.makeSnackbar( | |||
| view = binding.root, | |||
| message = getString(R.string.join_group_code_snackbar_guide_message), | |||
| message = stringOf(R.string.join_group_code_snackbar_guide_message), | |||
There was a problem hiding this comment.
헉 ㅋ 이거 확장함수 한번도 안 썼는데 "대거 리팩토링" 해야겠다링 ㅋ.ㅋ
| } | ||
| } | ||
|
|
||
| private fun moveToMyGroup() { |
There was a problem hiding this comment.
왜 여기는 flag를 추가해주지 않으셨는지!!
There was a problem hiding this comment.
요건 스택에 남아 있어야 해서요
| @@ -28,7 +29,7 @@ class ParticipantActivity : | |||
|
|
|||
| private fun initLayout() { | |||
| binding.rvParticipant.adapter = participantAdapter | |||
| participantViewModel.getParticipantList(1) | |||
| participantViewModel.getParticipantList(intent.getLongExtra(MEETING_ID, DEFAULT_VALUE)) | |||
| @@ -43,9 +44,11 @@ class ParticipantActivity : | |||
| is UiState.Success -> { | |||
| participantAdapter.submitList(uiState.data.participants) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
흠냐흠냐.. 린트체크만 하고 정렬은 안 하는 나!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20240118_023817.mp4
Uncompleted Tasks 😅
To Reviewers 📢
앱 종료 스낵바 디자인 측이랑 얘기해서 만들었습니다.
내 단체 뷰가 참여자 페이지와 연결되어 있어서 내 단체 뷰 페이지 새로 만들어서 연결하였습니다.