[refactor] 지도 카드 뷰 로직 리팩토링 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doreminwoo
approved these changes
Jan 16, 2024
Comment on lines
+32
to
+33
| marginStart = SNACKBAR_MARGIN.toPx() | ||
| marginEnd = SNACKBAR_MARGIN.toPx() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
뷰가 바뀐 부분은 없어서 생략할게요.
Uncompleted Tasks 😅
To Reviewers 📢
상수화 하고,, 날짜 관련 확장함수 만들었어용
내용 요약/확인 페이지랑 지도 카드에는 적용했습니당
나머지는 각자 부탁드려용
원래 메인 지도 뷰의 로직적인 부분을 수정하고 싶었는데 카드 슬라이드 기능 구현하면서 로직적인 부분이 정리된 것 같아서 안 했습니당