[fix] 1차 QA 수정사항 반영 - 지은 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunniiii
approved these changes
Jan 14, 2024
| @@ -50,8 +50,7 @@ class PlanViewModel @Inject constructor( | |||
| private val _selectedCategory = MutableStateFlow<CategoryType?>(null) | |||
| val selectedCategory get() = _selectedCategory.asStateFlow() | |||
|
|
|||
| private val _selectedRecruitment = MutableStateFlow<String?>("1") | |||
| val selectedRecruitment get() = _selectedRecruitment.asStateFlow() | |||
| val selectedRecruitment = MutableStateFlow("1") | |||
| (currentPage == PlanType.OPENCHATTING.position && planOpenChattingLink.isNotBlank()) || | ||
| (currentPage == PlanType.SUMMARY.position) | ||
| }.stateIn(viewModelScope, SharingStarted.WhileSubscribed(), false) | ||
|
|
||
| private fun checkRecruitment(selectedRecruitment: String): Boolean { | ||
| val recruitment = selectedRecruitment.toInt() | ||
| if (recruitment in 2..99) return true |
Doreminwoo
reviewed
Jan 14, 2024
| fun incRecruitmentNum() { | ||
| selectedRecruitment.value?.toInt()?.let { setSelectedRecruitment(it.plus(1).toString()) } | ||
| selectedRecruitment.value.toInt().let { setSelectedRecruitment(it.plus(1).toString()) } |
| @@ -195,7 +204,7 @@ class PlanViewModel @Inject constructor( | |||
| runCatching { | |||
| _selectedCategory.value?.let { selectedCategory -> | |||
| _selectedLocation.value?.let { selectedLocation -> | |||
| _selectedRecruitment.value?.let { selectedRecruitment -> | |||
| selectedRecruitment.value?.let { selectedRecruitment -> | |||
| @@ -58,7 +59,8 @@ class PlanRecruitmentFragment : | |||
|
|
|||
| private fun collectData() { | |||
| viewModel.selectedRecruitment.flowWithLifecycle(lifecycle).onEach { selectedRecruitment -> | |||
| when (selectedRecruitment.toString()) { | |||
| when (selectedRecruitment) { | |||
| INVALID_RECRUITMENT -> viewModel.setSelectedRecruitment("1") | |||
| @@ -64,7 +64,7 @@ | |||
| android:inputType="number" | |||
| android:maxLength="2" | |||
| android:paddingVertical="@dimen/spacing28" | |||
| android:text="@{planViewModel.selectedRecruitment}" | |||
| android:text="@={planViewModel.selectedRecruitment}" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
XRecorder_15012024_022344.mp4
Uncompleted Tasks 😅
N/A
To Reviewers 📢
흠냥 바인딩어댑터 @JvmStatic @InverseMethod 이런 거 쓰면서 삽질하고 있었는데
그냥 val로 선언하면 해결되는 문제였슴ㅋㅅㅋㅜ..
Thanks to 건빵레포