[fix] 1차 QA 반영 -다은 #134
Merged
[fix] 1차 QA 반영 -다은 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunniiii
reviewed
Jan 14, 2024
HAJIEUN02
approved these changes
Jan 14, 2024
| @@ -42,6 +43,11 @@ class PingleEditText @JvmOverloads constructor( | |||
|
|
|||
| val hint = getString(R.styleable.pingleEditText_hint) | |||
| binding.etEditText.hint = hint | |||
|
|
|||
| val maxLength = getInt(R.styleable.pingleEditText_maxLength, -1) | |||
There was a problem hiding this comment.
쩐다.. maxLength 어떻게 하나 했나 했는데 이렇게 하는 거였군요
There was a problem hiding this comment.
한번도 attrs를 써본 적이 없어서 방금 검색해봤는데요.. 보통 커스텀 위젯을 사용할 때에만 사용하는 속성인 거 맞나요?
Doreminwoo
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
HD20240114_230017.1.mp4
HD20240114_230103.1.mp4