[faet] 기존단체입장 초대코드 api 통신 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/org/sopt/pingle/di/DataSourceModule.kt # app/src/main/java/org/sopt/pingle/di/RepositoryModule.kt # app/src/main/java/org/sopt/pingle/di/ServiceModule.kt # app/src/main/java/org/sopt/pingle/di/UseCaseModule.kt
2 tasks
|
저기 영상이 안 보여요 |
jihyunniiii
reviewed
Jan 12, 2024
app/src/main/AndroidManifest.xml
Outdated
| android:exported="false" | ||
| android:exported="true" |
There was a problem hiding this comment.
RequestJoinGroupCodeEntityMapper
Comment on lines
12
to
14
| fun toRequestJoinGroupCode() = RequestJoinGroupCodeEntity( | ||
| code = this.code | ||
| ) |
There was a problem hiding this comment.
이거 사용 되나요? 사용되지 않는다면 지워줍시다
| @POST("$VERSION/$TEAMS/{$TEAM_ID}/$REGISTER") | ||
| suspend fun postJoinGroupCode( | ||
| @Path("$TEAM_ID") teamId: Int, | ||
| @Body code: RequestJoinGroupCodeDto |
There was a problem hiding this comment.
Suggested change
| @Body code: RequestJoinGroupCodeDto | |
| @Body requestJoinGroupCodeDto: RequestJoinGroupCodeDto |
Comment on lines
+77
to
+81
| is UiState.Error -> Timber.tag(JOIN_GROUP_CODE_ACTIVITY).d(uiState.message) | ||
|
|
||
| is UiState.Loading -> Timber.tag(JOIN_GROUP_CODE_ACTIVITY).d(LOADING) | ||
|
|
||
| is UiState.Empty -> Timber.tag(JOIN_GROUP_CODE_ACTIVITY).d(EMPTY) |
| PingleSnackbar.makeSnackbar( | ||
| binding.root, | ||
| getString(R.string.join_group_code_snackbar_message), | ||
| 97 |
There was a problem hiding this comment.
저기,, 혹시 얘도 dimen 이용하거나 상수화 해주실 수 있으실지,,
| participantCount = 200 | ||
| ) | ||
| fun getJoinGroupInfo(teamId: Int) { | ||
| _joinGroupCodeState.value = UiState.Loading |
There was a problem hiding this comment.
네이밍이 JoingGroupInfoState가 되어야 하지 않을까요? 넘 헷갈리는디 ㅜ
|
|
||
| fun postJoinGroupCode(teamId: Int, code: RequestJoinGroupCodeEntity) { | ||
| _joinGroupCode.value = UiState.Loading |
There was a problem hiding this comment.
얘도 joinGroupCodeState로 바꿔주세요
| viewModelScope.launch { | ||
| _joinGroupCodeState.value = UiState.Loading | ||
| runCatching { | ||
| getJoinGroupInfoUseCase.invoke(teamId = teamId).collect { joinGroupInfo -> |
There was a problem hiding this comment.
Suggested change
| getJoinGroupInfoUseCase.invoke(teamId = teamId).collect { joinGroupInfo -> | |
| getJoinGroupInfoUseCase(teamId = teamId).collect { joinGroupInfo -> |
유즈케이스에서 invoke를 재정의 했기 때문에 이렇게 사용 가능합니다 나머지도 고쳐주세오
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Recording_2024-01-12-03-13-11.mp4
Uncompleted Tasks 😅
N/A
To Reviewers 📢
어렵네요..........