[feat] 번개 참여 및 취소하기 API 연동 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAJIEUN02
approved these changes
Jan 11, 2024
| override suspend fun postPingleJoin(meetingId: Long): NullableBaseResponse<Unit?> = | ||
| pingleService.postPingleJoin(meetingId = meetingId) | ||
|
|
||
| override suspend fun postPingleCancel(meetingId: Long): NullableBaseResponse<Unit?> = |
There was a problem hiding this comment.
없는 경우에는 그냥 BaseResponse안 쓰고 Call하면 된다고 생각했는데 Call은 enqueue에만 쓰이는 개념이라는 걸 오늘 알게 되었습니다.. 대박
| AllModalDialogFragment( | ||
| title = stringOf(R.string.map_cancel_modal_title), | ||
| detail = stringOf(R.string.map_cancel_modal_detail), | ||
| buttonText = stringOf(R.string.map_cancel_modal_button_text), | ||
| textButtonText = stringOf(R.string.map_cancel_modal_text_button_text), | ||
| clickBtn = { }, | ||
| clickTextBtn = { }, | ||
| onDialogClosed = { } |
| @@ -33,9 +37,12 @@ class MapViewModel @Inject constructor( | |||
| private var _selectedMarkerPosition = MutableStateFlow(DEFAULT_SELECTED_MARKER_POSITION) | |||
| val selectedMarkerPosition get() = _selectedMarkerPosition.asStateFlow() | |||
|
|
|||
| private val _pingleListState = MutableSharedFlow<UiState<List<PingleEntity>>>() | |||
| private val _pingleListState = MutableSharedFlow<UiState<Pair<Long, List<PingleEntity>>>>() | |||
There was a problem hiding this comment.
허걱!!! Long과 PingleEntity List 두가지를 한꺼번에 return하기 위해 사용한 건가욤??!?!? 야무야무
| @@ -165,6 +165,8 @@ | |||
| android:layout_width="wrap_content" | |||
| android:layout_height="wrap_content" | |||
| android:textAppearance="@style/TextAppearance.Pingle.Sub.Semi.16" | |||
| android:layout_marginEnd="2dp | |||
| " | |||
# Conflicts: # app/src/main/java/org/sopt/pingle/di/DataSourceModule.kt # app/src/main/java/org/sopt/pingle/di/RepositoryModule.kt # app/src/main/java/org/sopt/pingle/di/ServiceModule.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20240111_205649.mp4
Uncompleted Tasks 😅
To Reviewers 📢
ㅋㅋ 다했당