[Feat/igw-33/41] - 서류 지원 상태 상세 조회 구현하기 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
MrMirror21
reviewed
Oct 25, 2024
Comment on lines
23
to
38
| <div className="flex gap-[1.125rem]"> | ||
| <div className="flex flex-col items-center"> | ||
| {stepIconStyler(1)} | ||
| <div | ||
| className={`w-[0.125rem] h-[3.5rem] ${step > 1 ? 'bg-[#1E1926]' : 'bg-[#F2F2F2]'}`} | ||
| ></div> | ||
| </div> | ||
| <div> | ||
| <h5 className={`${step > 1 ? 'head-3' : 'body-1'} text-[#464646]`}> | ||
| Resume Verification | ||
| </h5> | ||
| <p className="caption-2 text-[#656565]"> | ||
| The employer is currently reviewing your resume. | ||
| </p> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
저도 지금 통합 신청서 작업하면서 하게 된건데, 아래와 같이 겉 UI 부분만 컴포넌트화하면 좋을 것 같아요. 한 3~4개까지는 그래도 복붙으로 할 만한데, 5,6개 넘어가기 시작하니까 주석을 달아도 나중에 해당하는 부분 찾기가 어렵더라구요. inline으로 늘어지는 tailwind라서 그런 점이 더 부각되는 것 같아요. 순간 styled-components가 그리워지는..
// 반복문으로 1 ~ 7까지 stage props로 전달
<div className="flex gap-[1.125rem]">
<div className="flex flex-col items-center">
{stepIconStyler(step)}
<div
className={`w-[0.125rem] h-[3.5rem] ${step > stage ? 'bg-[#1E1926]' : 'bg-[#F2F2F2]'}`}
></div>
</div>
<div>
<h5 className={`${step > stage ? 'head-3' : 'body-1'} text-[#464646]`}>
{title}
</h5>
{children}
</div>
</div>
Comment on lines
+51
to
+72
| const showCurrentStepButton = (step: number) => { | ||
| switch (step) { | ||
| case 1: | ||
| return <ApplicationDetailStep1 />; | ||
| case 2: | ||
| return <ApplicationDetailStep2 />; | ||
| case 3: | ||
| return <ApplicationDetailStep3 />; | ||
| case 4: | ||
| return <ApplicationDetailStep4 />; | ||
| case 5: | ||
| return <ApplicationDetailStep5 />; | ||
| case 6: | ||
| return <ApplicationDetailStep6 />; | ||
| case 7: | ||
| return <ApplicationDetailStep7 result={APPICATION_DETAIL_DATA.step} />; | ||
| default: | ||
| return ( | ||
| <ApplicationDetailStepEtc result={APPICATION_DETAIL_DATA.step} /> | ||
| ); | ||
| } | ||
| }; |
There was a problem hiding this comment.
step 장난 아니네요.. 수고하셨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢
구현 결과 : step1
구현 결과 : step2
2024-10-25.4.32.37.mov
구현 결과 : step3
2024-10-25.4.33.11.mov
구현 결과 : step4
2024-10-25.4.33.32.mov
구현 결과 : step5
2024-10-25.4.33.56.mov
구현 결과 : step6
2024-10-25.4.34.20.mov
구현 결과 : Pending
구현 결과 : RESUME_REJECTED
구현 결과 : step7