-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEV 2] Layers File Fix for recent update #387
base: 386-sev-2-layers-file-broken-on-recent-update
Are you sure you want to change the base?
[SEV 2] Layers File Fix for recent update #387
Conversation
Fix for the relevant issue Team-Silver-Sphere#386
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please provide logs from https://raw.githubusercontent.com/Squad-Wiki/squad-wiki-pipeline-map-data/dev/completed_output/_Current%20Version/finished.json
showing proper loading to ensure this passes. If so I'll push and bump the RC1 release to prod. @Shanomac99 so you can find the git versioning corrections.
If all passes will be pushed when I wake back up.
Team don't push yet please. |
tickets: team.tickets, | ||
commander: team.commander, | ||
vehicles: (team.vehicles || []).map((vehicle) => ({ | ||
name: vehicle.type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there some custom plugins that use this data still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think dave's mapvote uses to show what the layer have as vehicles in the broadcast. But since the new layer list doesn't provide this info anymore we can't get that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
best thing for custom plugins would be set it as empty array
Fix for #386