Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEV 2] Layers File Fix for recent update #387

Open
wants to merge 2 commits into
base: 386-sev-2-layers-file-broken-on-recent-update
Choose a base branch
from

Conversation

watchful-eyes
Copy link

Fix for #386

@werewolfboy13 werewolfboy13 changed the base branch from master to 386-sev-2-layers-file-broken-on-recent-update October 26, 2024 11:55
Copy link
Collaborator

@werewolfboy13 werewolfboy13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide logs from https://raw.githubusercontent.com/Squad-Wiki/squad-wiki-pipeline-map-data/dev/completed_output/_Current%20Version/finished.json showing proper loading to ensure this passes. If so I'll push and bump the RC1 release to prod. @Shanomac99 so you can find the git versioning corrections.

If all passes will be pushed when I wake back up.

@watchful-eyes
Copy link
Author

image
image

don't know what you need exactly so hope these should suffice

@werewolfboy13
Copy link
Collaborator

Team don't push yet please.

tickets: team.tickets,
commander: team.commander,
vehicles: (team.vehicles || []).map((vehicle) => ({
name: vehicle.type,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there some custom plugins that use this data still?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think dave's mapvote uses to show what the layer have as vehicles in the broadcast. But since the new layer list doesn't provide this info anymore we can't get that

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best thing for custom plugins would be set it as empty array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants