Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add ability to manage Icrc1 tokens #81

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

aligatorr89
Copy link
Collaborator

@aligatorr89 aligatorr89 commented Jan 9, 2025

Ability to manage tokens in frontend. Tokens are persisted for great UX.

image

Mobile:

image

@aligatorr89 aligatorr89 force-pushed the feature-request-1413707-wallet-tokens branch 4 times, most recently from 12a57c4 to 0b38f6b Compare January 10, 2025 11:42
@taggrx
Copy link
Contributor

taggrx commented Jan 19, 2025

Do you mind if I work on top of this PR a bit to consolidate the TAGGR tokens UI section with the new wallet?

src/frontend/src/api.ts Outdated Show resolved Hide resolved
src/frontend/src/api.ts Outdated Show resolved Hide resolved
src/frontend/src/util.ts Outdated Show resolved Hide resolved
src/frontend/src/icrc1-tokens-wallet.tsx Outdated Show resolved Hide resolved
@aligatorr89
Copy link
Collaborator Author

aligatorr89 commented Jan 21, 2025

Do you mind if I work on top of this PR a bit to consolidate the TAGGR tokens UI section with the new wallet?

not at all :) . Let me know if you need any help or want to split something.

@taggrx taggrx force-pushed the feature-request-1413707-wallet-tokens branch from 2dc7cd9 to 314dd6a Compare January 26, 2025 09:13
@taggrx
Copy link
Contributor

taggrx commented Jan 26, 2025

@aligatorr89 pushed changes, however the persistence of the token lists is in browser only... this is a recipe for endless enquiries from users :) I think it should be simply stored on the user object. Can you please add this?

@aligatorr89
Copy link
Collaborator Author

aligatorr89 commented Jan 26, 2025

@aligatorr89 pushed changes, however the persistence of the token lists is in browser only... this is a recipe for endless enquiries from users :) I think it should be simply stored on the user object. Can you please add this?

I will add canister persistence. Thanks for your invaluable fixes!

@aligatorr89 aligatorr89 force-pushed the feature-request-1413707-wallet-tokens branch 2 times, most recently from b4b2f8a to c31d47d Compare January 27, 2025 11:41
@aligatorr89 aligatorr89 reopened this Jan 27, 2025
@aligatorr89
Copy link
Collaborator Author

aligatorr89 commented Jan 27, 2025

@aligatorr89 pushed changes, however the persistence of the token lists is in browser only... this is a recipe for endless enquiries from users :) I think it should be simply stored on the user object. Can you please add this?

I added to update_user mutation, which is big and can cause issues longterm, because parameters are overwritten. Let me know if it's ok.

added update_user_icrc_canisters for simplicity

@aligatorr89 aligatorr89 force-pushed the feature-request-1413707-wallet-tokens branch 8 times, most recently from 2d9b432 to e53a21a Compare January 27, 2025 22:22
@taggrx taggrx force-pushed the feature-request-1413707-wallet-tokens branch from e53a21a to 6acbd5f Compare February 1, 2025 09:41
@taggrx taggrx force-pushed the feature-request-1413707-wallet-tokens branch from 6acbd5f to 995bcc5 Compare February 1, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants