Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port file trashing (#409) to v9.5 #792

Merged
merged 5 commits into from
Feb 6, 2025
Merged

feat: port file trashing (#409) to v9.5 #792

merged 5 commits into from
Feb 6, 2025

Conversation

CyanVoxel
Copy link
Member

@CyanVoxel CyanVoxel commented Feb 5, 2025 •
edited
Loading

Summary

This PR ports #409 to main/v9.5. Additional changes include moving strings to the translation files.

Closes #659.

@CyanVoxel CyanVoxel added Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience Priority: High An important issue requiring attention Type: File System File system interactions labels Feb 5, 2025
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Feb 5, 2025
Computerdores
Computerdores approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits and one other issue, but I think this could already be merged as is

tagstudio/resources/translations/en.json Outdated Show resolved Hide resolved
tagstudio/src/qt/ts_qt.py Outdated Show resolved Hide resolved
tagstudio/src/qt/ts_qt.py Outdated Show resolved Hide resolved
tagstudio/resources/translations/en.json Outdated Show resolved Hide resolved
tagstudio/src/qt/ts_qt.py Show resolved Hide resolved
tagstudio/src/qt/widgets/preview/preview_thumb.py Outdated Show resolved Hide resolved
@CyanVoxel
Copy link
Member Author

Implemented feedback, thank you for the review!

@CyanVoxel CyanVoxel merged commit a3df70b into main Feb 6, 2025
10 checks passed
@CyanVoxel CyanVoxel deleted the trash-sql branch February 6, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Computerdores Computerdores Computerdores approved these changes

Assignees
No one assigned
Labels
Priority: High An important issue requiring attention Type: Enhancement New feature or request Type: File System File system interactions Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
TagStudio Development
Status: ✅ Done
Milestone
SQL Parity
Development

Successfully merging this pull request may close these issues.

[Parity]: Port file trashing/deleting from v9.4 to v9.5
2 participants
@CyanVoxel @Computerdores