[TASK] Update permalink redirect matching for proper std:label #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"std:label" is the authoritative lookup key in the objects.inv.json files. All other "std:..." definitions are fallback only. This patch ensures that 'std:label' receives priority, and all other lookups are only in case of "old style" permalinks or file name based permalinks. The unit test is adapted to also contain the two new link types "console-command" and "console-command-list" (together with fallback resolve for "confval" and "confval-menu").
linawolf
approved these changes
Jan 20, 2025
andreaskienast
requested changes
Jan 23, 2025
Co-authored-by: Andreas Kienast <[email protected]>
Also refactor index key matching to use simplified version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"std:label" is the authoritative lookup key in the objects.inv.json
files. All other "std:..." definitions are fallback only.
This patch ensures that 'std:label' receives priority, and all
other lookups are only in case of "old style" permalinks or
file name based permalinks.
The unit test is adapted to also contain the two new link
types "console-command" and "console-command-list" (together
with fallback resolve for "confval" and "confval-menu").
The unit test fixtures are also updated.