Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Course and user endpoints for API v2 #1429

Merged
merged 16 commits into from
Jan 29, 2025
Merged

Course and user endpoints for API v2 #1429

merged 16 commits into from
Jan 29, 2025

Conversation

carlobortolan
Copy link
Member

@carlobortolan carlobortolan commented Jan 10, 2025 •
edited
Loading

Motivation and Context

See #1415.

Description

  • Add user-facing course and user endpoints of new gRPC API
  • Remove duplicate method in web/index.go and api/courses.go

Steps for Testing

Test gRPC API:

  1. Fork postman.com/tumdev/team-workspace/collection/66dba0f1406ecba7a2d44836 or use api_v2.proto
  2. Try out different requests

Test HTTP/REST proxy:

  1. Open localhost:8081/api/v2/docs
  2. Try out different requests

Screenshots

List of current endpoints:
image

@carlobortolan carlobortolan self-assigned this Jan 10, 2025
@carlobortolan carlobortolan marked this pull request as ready for review January 10, 2025 13:37
@carlobortolan carlobortolan mentioned this pull request Jan 11, 2025
Open
10 tasks
kordianbruck
kordianbruck previously requested changes Jan 15, 2025
View reviewed changes
api_v2/README.md Outdated Show resolved Hide resolved
@joschahenningsen joschahenningsen self-requested a review January 28, 2025 16:05
joschahenningsen
joschahenningsen approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@joschahenningsen joschahenningsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@carlobortolan carlobortolan merged commit be8cc02 into dev Jan 29, 2025
9 checks passed
@carlobortolan carlobortolan deleted the api_v2 branch January 29, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschahenningsen joschahenningsen joschahenningsen approved these changes

@kordianbruck kordianbruck Awaiting requested review from kordianbruck

Assignees

@carlobortolan carlobortolan

Labels
awaiting feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlobortolan @kordianbruck @joschahenningsen