-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/conviva device metadata #63
Changes from 6 commits
5487217
ab04ab5
189bc31
ae5275f
50fb6fa
46849a6
bd5d7a2
ff07e52
d3eca0c
951bf31
0a8c3c1
3394dfd
df5bc55
1ce3f34
ab445e1
a14998e
e6d32e0
d8e02a3
b23a1f5
6a2caf5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@theoplayer/conviva-connector-web": minor | ||
--- | ||
|
||
Added `deviceMetadata` property to `ConvivaConfiguration`. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,20 @@ | |
const convivaConfig = { | ||
debug: false, | ||
gatewayUrl: 'CUSTOMER_GATEWAY_GOES_HERE', | ||
customerKey: 'CUSTOMER_KEY_GOES_HERE' // Can be a test or production key. | ||
customerKey: 'CUSTOMER_KEY_GOES_HERE', // Can be a test or production key. | ||
deviceMetadata: { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we want to have this specific device metadata on our test page while we can't know the users setup? It is already mentioned in the README that it is an option to set this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✅ |
||
[Conviva.Constants.DeviceMetadata.BRAND]: "Chrome", | ||
[Conviva.Constants.DeviceMetadata.MANUFACTURER]: "Apple", | ||
[Conviva.Constants.DeviceMetadata.MODEL]: "MacBook Pro M2", | ||
[Conviva.Constants.DeviceMetadata.TYPE]: Conviva.Client.DeviceType.DESKTOP, | ||
[Conviva.Constants.DeviceMetadata.VERSION]: "131.0.6778.86", | ||
[Conviva.Constants.DeviceMetadata.OS_NAME]: "macOS Sonoma", | ||
[Conviva.Constants.DeviceMetadata.OS_VERSION]: "14.7.0", | ||
[Conviva.Constants.DeviceMetadata.CATEGORY]: Conviva.Client.DeviceCategory.APPLE_DEVICE, | ||
[Conviva.Constants.DeviceMetadata.SCREEN_RESOLUTION_WIDTH]: 3024, | ||
[Conviva.Constants.DeviceMetadata.SCREEN_RESOLUTION_HEIGHT]: 1964, | ||
[Conviva.Constants.DeviceMetadata.SCREEN_RESOLUTION_SCALE_FACTOR]: 1 | ||
} | ||
}; | ||
|
||
const convivaIntegration = new THEOplayerConvivaConnector.ConvivaConnector( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to open the pages folder instead? Then they can choose our other pages more easily if they wanna test yospace for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅