New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Impl DTO validation of User #119

Open

celi1004 wants to merge 1 commit into TEAMOTTDEVELOPERS:develop from celi1004:feat/UserValidation

Contributor

celi1004 commented Feb 13, 2022

Related Issue

Resolve : #(Issue number)

Description

UserCreateRequestDTO, UserSignInDTO에 validation 관련 어노테이션(NotEmpty, NotNull 등) 추가
UserController에 Valid 어노테이션 추가
GlobalExceptionHandler에 DTO validation 체크용 exceptionHandler 구현
SocialProvider 값 체크가 안돼있어서 그것도 추가했습니다

Discussion

validation annotation에 email 포맷체크도 있는데, 우리 userId 필드가 (일반회원-이메일, 소셜회원-소셜아이디)라서 못쓰는게 아쉽네요.. 따로 email 포맷체킹을 해줘야할까요
xd 회원가입 화면엔 전화번호 넣는 칸이 없는데, User에는 phoneNum이 있음. 우리 전화번호 필요한가?가 의문


          feat: Impl DTO validation of User

84fa3de

celi1004 requested a review from selgyun

February 15, 2022 15:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet