Feat: 마이페이지 #57
Merged
Feat: 마이페이지 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 9b62af7): https://hearus-668d7--pr57-feat-my-page-9inrejrg.web.app (expires Wed, 28 Aug 2024 11:06:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bf5e680be215afe513793a0ffcca015694c306c5 |
Nangniya
approved these changes
Aug 21, 2024
Comment on lines
1
to
6
| import { useState } from 'react'; | ||
| import styles from './SupplementaryInfoModal.module.scss'; | ||
| import Next from '../../../../assets/images/arrow/next-arrow.svg?react'; | ||
| import Back from '../../../../assets/images/arrow/back-arrow.svg?react'; | ||
| import { useQueryClient, useMutation } from '@tanstack/react-query'; | ||
| import { SupplementaryUpdateInfo } from '../../../../apis/user'; |
There was a problem hiding this comment.
import문 순서를
- react
- react-router-dom
- @tanstack/react-query, zustand 등 라이브러리
- 컴포넌트
- assets, constants
- api, util 등 기타 함수
- style
이런 순서로 불러오려고 하고있거든요 별건 아니지만 정리되면 좋습니당
There was a problem hiding this comment.
앗 맞아요!!! 이것도 물어보려고 했는데 감사합니당 ㅎㅎㅎ
src/pages/Main/Mypage/Mypage.tsx
Outdated
Comment on lines
127
to
131
| {currentPage === 'view' ? ( | ||
| <View info={info} onEditClick={handleEditClick} /> | ||
| ) : ( | ||
| <Edit info={info} setInfo={setInfo} onSaveClick={handleSaveClick} /> | ||
| )} |
There was a problem hiding this comment.
페이지 url이 바뀌는게 아니기때문에 이름을 currentMode로 하는게 더 좋을것같아요!
There was a problem hiding this comment.
오...!! 맞네요 넵 바꿔서 다시 올리고 머지하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 (Summary)
마이페이지, 추가정보 모달, 네이버 로그인, 전체 페이지 padding 통일
변경 사항 (Changes)
리뷰 요구사항
확인 방법 (선택)