Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: 시간표 색상 변수 관리 #35

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

Nangniya
Copy link
Contributor

@Nangniya Nangniya commented Aug 2, 2024

요약 (Summary)

시간표 색상 서버에서 제공하는 색상으로 수정

변경 사항 (Changes)

  • getRandomColor -> getScheduleColor로 변경 (랜덤 방식이 아니게 됐기 때문)
  • colors.ts 제거 -> schedule.ts로 이동
  • 배경색과 폰트색을 COLORS 객체 하나에 담음

리뷰 요구사항

COLORS 객체를 이용해 서버에서 주는 데이터의 colors에 따라 배경색과 폰트색을 설정하는 방식으로 바꾸기 위해
getScheduleColor 함수에 파라미터를 생성했습니다.

export const COLORS = {
  '#FFD6D6': '#733232', // Pink
  '#FFF3D6': '#733232', // Orange
  '#FEFFD6': '#733232', // Yellow
  '#D6FFDA': '#327354', // Green
  '#D6DFFF': '#323973', // Blue
  '#D6F8FF': '#326073', // BlueGreen
  '#EAD6FF': '#6E3273', //Purple
};

시간표 추가할때 색상도 이 변수 사용하면 됩니다.

확인 방법 (선택)

image

Copy link

github-actions bot commented Aug 2, 2024

Visit the preview URL for this PR (updated for commit c24f02a):

https://hearus-668d7--pr35-feat-test-make-6uzagm14.web.app

(expires Fri, 09 Aug 2024 08:43:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf5e680be215afe513793a0ffcca015694c306c5

@Nangniya Nangniya merged commit 8f92fe5 into develop Aug 2, 2024
2 checks passed
@Nangniya Nangniya deleted the feat/test-make branch August 2, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant