Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: useRecord 성능 개선 #107

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Refactor: useRecord 성능 개선 #107

merged 1 commit into from
Nov 11, 2024

Conversation

Nangniya
Copy link
Contributor

요약 (Summary)

useRecord 리팩토링 성능 개선

변경 사항 (Changes)

  • MediaRecorder 객체를 주기적으로 생성하는 것 방지
  • ondataavailable에 할당하는 함수를 따로 선언 후 할당
  • mediaRecorder.start의 인수에 3000ms 전달

리뷰 요구사항

확인 방법 (선택)

- MediaRecorder 객체를 주기적으로 생성하는 것 방지
- ondataavailable에 할당하는 함수를 따로 선언 후 할당
- mediaRecorder.start의 인수에 3000ms 전달
Copy link

Visit the preview URL for this PR (updated for commit ca149f5):

https://hearus-668d7--pr107-refactor-record-7osjyspn.web.app

(expires Mon, 18 Nov 2024 12:24:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bf5e680be215afe513793a0ffcca015694c306c5

@Nangniya Nangniya merged commit 1091011 into develop Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant