Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

Add ARIA labels to settings page - Vue #397

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

Adjoa
Copy link
Contributor

@Adjoa Adjoa commented Oct 30, 2024

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ New Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 👷 Example Application
  • 🎨 Design
  • 📖 Content
  • 🧪 Tests
  • 🔖 Release
  • 🚩 Other

Description

This PR adds the following accessibility enhancements to the settings page:

  • associates profile image label with its input
  • labels main element, settings form, and Save button in its loading state

Related Tickets & Documents

Resolves #79

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

No tests? Add a note

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 general documentation
  • 🙅 no documentation needed

No docs? Add a note

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@Adjoa Adjoa changed the title Vue settings page aria Add ARIA labels to settings page - Vue Oct 30, 2024
@Adjoa Adjoa marked this pull request as ready for review October 30, 2024 20:38
Copy link
Contributor

@blackgirlbytes blackgirlbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@blackgirlbytes blackgirlbytes merged commit 9a7c524 into TBD54566975:main Oct 31, 2024
22 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ARIA labels to settings page - Vue
2 participants