Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Copy Model' context menu option #8

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Add 'Copy Model' context menu option #8

merged 4 commits into from
Dec 15, 2023

Conversation

adamnejm
Copy link
Contributor

Made it play a sound, because I'm cool like that

Derpius
Derpius approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@Derpius Derpius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits, but otherwise looks good!

lua/sh-tas-utils/copymodelproperty.lua Outdated Show resolved Hide resolved
lua/sh-tas-utils/copymodelproperty.lua Show resolved Hide resolved
lua/sh-tas-utils/copymodelproperty.lua Outdated Show resolved Hide resolved
@Derpius
Copy link
Member

Derpius commented Dec 15, 2023

QA Result: Passed ✅

  • Copy model item is available in the context menu for valid ents with the correct icon ✅
  • Clicking copies the model path to my clipboard, and plays a sound ✅
  • Copy model item is not available for invalid ents or players ⚠️
    • I was unable to test this as players don't seem to be right-clickable in the context menu.

@Derpius Derpius merged commit f62fc33 into TAServers:master Dec 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Derpius Derpius Derpius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
TAS Review Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamnejm @Derpius