Refactor Better ChatPrint and fix size limit #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
TASUtils.getChatPrintMessageSizeBits
global to calculate the size of a chat print message before trying to sendencodeMsg
to have a clearer name and to not check the message size mid-sendBroadcast
andChatPrint
functions to check the message size and error before starting the netmsgnet.WriteColor
withnet.WriteUInt
WriteColor
usesWriteUInt
under the hood, but this way we ignore some useless checks and have confidence in parity between our writer and size calculator functionsImpact
Testing
TASUtils.Broadcast
andPlayer:ChatPrint()
are essentially the same code, so can fully test one and then smoke test the otherchat.AddText
message