-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ulx cleanropes
to clean ropes only connected to world
#16
base: master
Are you sure you want to change the base?
Conversation
Ugh gotta install the GLuaLinter as well ;f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm torn between whether it should cleanup all world ropes always, or all ropes owned by a target player (or players) though
Btw you can branch directly within this repo (and any others) now that I've added you to the org. You can also see private repos owned and co-owned by the GMod team. |
I don't think there's many uses for placing ropes on world itself, normal players generally just spawn a plate and put ropes on that to make signs and whatnot. But your regular minge is just gonna grab the rope tool, start spinning around and left clicking. |
Good to know, maybe I will try it later. |
That said, NADMOD correctly sets owner of the rope, so I can make it require a player argument. Up to you. |
I think it's fine as-is given we currently have no command. Can always change it if needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted a functional issue when I went to do the QA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, will do the QA tomorrow
Fixes: #11