Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ulx cleanropes to clean ropes only connected to world #16

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

adamnejm
Copy link
Contributor

Fixes: #11

@adamnejm
Copy link
Contributor Author

Ugh gotta install the GLuaLinter as well ;f

Copy link
Member

@Derpius Derpius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm torn between whether it should cleanup all world ropes always, or all ropes owned by a target player (or players) though

@Derpius
Copy link
Member

Derpius commented Dec 15, 2023

Btw you can branch directly within this repo (and any others) now that I've added you to the org. You can also see private repos owned and co-owned by the GMod team.

@adamnejm
Copy link
Contributor Author

Looks good. I'm torn between whether it should cleanup all world ropes always, or all ropes owned by a target player (or players) though

I don't think there's many uses for placing ropes on world itself, normal players generally just spawn a plate and put ropes on that to make signs and whatnot. But your regular minge is just gonna grab the rope tool, start spinning around and left clicking.

@adamnejm
Copy link
Contributor Author

Btw you can branch directly within this repo (and any others) now that I've added you to the org. You can also see private repos owned and co-owned by the GMod team.

Good to know, maybe I will try it later.

@adamnejm
Copy link
Contributor Author

adamnejm commented Dec 15, 2023

I don't think there's many uses for placing ropes on world itself, normal players generally just spawn a plate and put ropes on that to make signs and whatnot. But your regular minge is just gonna grab the rope tool, start spinning around and left clicking.

That said, NADMOD correctly sets owner of the rope, so I can make it require a player argument. Up to you.

@Derpius
Copy link
Member

Derpius commented Dec 15, 2023

I think it's fine as-is given we currently have no command. Can always change it if needed

Copy link
Member

@Derpius Derpius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a functional issue when I went to do the QA

lua/ulx/modules/sh/cleanropes.lua Outdated Show resolved Hide resolved
lua/ulx/modules/sh/cleanropes.lua Outdated Show resolved Hide resolved
@adamnejm adamnejm requested a review from Derpius December 28, 2023 00:03
Copy link
Member

@Derpius Derpius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, will do the QA tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add ropes cleanup
2 participants