Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash/exit instead of returning error for unsupported mappers #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Morilli
Copy link

@Morilli Morilli commented Jan 15, 2025

Should fix TASEmulators/BizHawk#4186.

BizHawk-side diff:

diff --git a/quicknes/bizinterface.cpp b/quicknes/bizinterface.cpp
index 81249c60d..29a7cbfee 100644
--- a/quicknes/bizinterface.cpp
+++ b/quicknes/bizinterface.cpp
@@ -37,10 +37,9 @@ QN_EXPORT void qn_delete(quickerNES::Emu *e)
 	free(e);
 }
 
-QN_EXPORT const char *qn_loadines(quickerNES::Emu *e, const void *data, int length)
+QN_EXPORT const char *qn_loadines(quickerNES::Emu *e, const uint8_t *data, int length)
 {
-	e->load_ines((const uint8_t*)data);
-	return 0;
+	return e->load_ines(data);
 }
 
 QN_EXPORT const char *qn_set_sample_rate(quickerNES::Emu *e, int rate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when loading Digital Devil Story: Megami Tensei
1 participant