Memoise a value during Lua lib function enumeration

TASEmulators · Jan 10, 2025 · 89e94be · 89e94be
1 parent ea810cb
commit 89e94be
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/BizHawk.Client.EmuHawk/tools/Lua/LuaLibraries.cs b/src/BizHawk.Client.EmuHawk/tools/Lua/LuaLibraries.cs
@@ -37,16 +37,18 @@ public LuaLibraries(
 
 			void EnumerateLuaFunctions(string name, Type type, LuaLibraryBase instance)
 			{
+				var libraryDesc = type.GetCustomAttributes(typeof(DescriptionAttribute), false).Cast<DescriptionAttribute>()
+					.Select(static descAttr => descAttr.Description)
+					.FirstOrDefault() ?? string.Empty;
 				if (instance != null) _lua.NewTable(name);
 				foreach (var method in type.GetMethods())
 				{
 					var foundAttrs = method.GetCustomAttributes(typeof(LuaMethodAttribute), false);
 					if (foundAttrs.Length == 0) continue;
 					if (instance != null) _lua.RegisterFunction($"{name}.{((LuaMethodAttribute)foundAttrs[0]).Name}", instance, method);
 					LibraryFunction libFunc = new(
-						name,
-						type.GetCustomAttributes(typeof(DescriptionAttribute), false).Cast<DescriptionAttribute>()
-							.Select(descAttr => descAttr.Description).FirstOrDefault() ?? string.Empty,
+						library: name,
+						libraryDescription: libraryDesc,
 						method,
 						suggestInREPL: false
 					);