Fix spyglass warning and add options #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed lint warning: Use [(7 - 1):0] (Value:[6:0]) instead of [0:(7 - 1)] for multibit signal.
The assert keyword inside the always_ff block causes the error 'ASSERT statements are not synthesizable. Ignoring for synthesis'. The assert keyword occurs inside the always_ff block, must be brought out and surrounded by macros that provide conditional compilation.
The always_ff block with additional logic is divided into always_comb and always_ff. This is necessary in order to explicitly have the values of the next signal.
|
A few things:
I'll still review the other changes in more detail and cherry-pick as appropriate. I see that one of your commits addresses issue #104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
fixed spyglass warning: Use [(N - 1):0] for multibit signal.
Added options for more flexible code generation.
Checklist