-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate metabolites identified by MetaNetX IDs #653
base: develop
Are you sure you want to change the base?
Conversation
instead of solving so many conflicts, would suggest to start a fresh PR from latest |
@haowang-bioinfo You mean have 1 commit for each ID that is changed? |
Instead of re-doing the commits, one can very simply "copy" commits with https://git-scm.com/docs/git-cherry-pick |
Perhaps it would have been better with more specific/clear instructions on how to proceed. First, it would be good to update the
Finally, based on this new branch, a new pull request can be created with the same message and this one. |
This is a great help! I can try this method for subsequent PR. Actually, there are so many mets should be changed in this PR, especially the references of MetaNetX ID. This may be due to the MetaNetX update. So, would we turn to MNX group for some help as discussion in #626? |
Yes, we will wait a little bit until get response from MNX group |
Main improvements in this PR:
As discussed in #626
remove mets
MAM03684e
for being duplicatesremove rxns
MAR09949
,MAR11292
,MAR11293
for being affected by duplicate metschange MetaNetX ID annotations for
MAM03226m
,MAM02550c
,MAM02550e
,MAM01421c
,MAM01421m
,MAM01421e
,MAM00719c
,MAM00719r
,MAM01759c
,MAM01759e
,MAM02425c
,MAM02425e
,MAM01677c
,MAM00272c
,MAM01321c
,MAM01321r
,MAM01321e
,MAM01321l
,MAM01060c
,MAM01322c
,MAM01631m
,MAM01824c
,MAM01824m
,MAM01996c
,MAM00382c
,MAM02040c
,MAM02040g
,MAM02040l
,MAM02040m
,MAM02040n
,MAM02040x
,MAM02040r
,MAM02040e
,MAM02144c
replace mets
I hereby confirm that I have:
develop
as a target branch