Skip to content

[Sketcher] Update parameter name and add comment #1196

[Sketcher] Update parameter name and add comment

[Sketcher] Update parameter name and add comment #1196

Triggered via push January 22, 2025 19:48
Status Success
Total duration 34m 54s
Artifacts 8

CI_master.yml

on: push
Prepare  /  Prepare
4s
Prepare / Prepare
Matrix: Pixi / build_with_pixi
WrapUp  /  WrapUp
3s
WrapUp / WrapUp
Fit to window
Zoom out
Zoom in

Annotations

1 error and 61 warnings
Lint / Lint
Process completed with exit code 1.
Prepare / Prepare
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Lint / Lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L79
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L80
Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L145
Use int16_t/int64_t/etc, rather than the C type long [runtime/int] [4]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L147
Using C-style cast. Use static_cast<uint32_t>(...) instead [readability/casting] [4]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L566
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L693
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L696
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L810
Use int16_t/int64_t/etc, rather than the C type short [runtime/int] [4]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L817
Using deprecated casting style. Use static_cast<float>(...) instead [readability/casting] [4]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L817
Using C-style cast. Use static_cast<float>(...) instead [readability/casting] [4]
Lint / Lint
variable 'count' set but not used [-Wunused-but-set-variable]
Lint / Lint
variable 'nsuper_et' set but not used [-Wunused-but-set-variable]
Lint / Lint
variable 'nsuper_et_post' set but not used [-Wunused-but-set-variable]
Lint / Lint: build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
Lint / Lint: build/_deps/fmt-src/include/fmt/core.h#L2197
fmt::detail::specs_setter has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
Lint / Lint: build/_deps/fmt-src/include/fmt/core.h#L2233
fmt::detail::dynamic_specs_handler has copy-ctor but not dtor, copy-assignment [-Wclazy-rule-of-three]
Lint / Lint: build/_deps/fmt-src/include/fmt/core.h#L3126
Pass small and trivially-copyable type by value (const signed char &) [-Wclazy-function-args-by-value]
Lint / Lint: build/_deps/fmt-src/include/fmt/core.h#L3127
Pass small and trivially-copyable type by value (const unsigned char &) [-Wclazy-function-args-by-value]
Lint / Lint: build/_deps/fmt-src/include/fmt/core.h#L3128
Pass small and trivially-copyable type by value (const short &) [-Wclazy-function-args-by-value]
Lint / Lint: build/_deps/fmt-src/include/fmt/core.h#L3129
Pass small and trivially-copyable type by value (const unsigned short &) [-Wclazy-function-args-by-value]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L145
use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L249
0.7f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L249
floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L249
0.7f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L249
floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L249
0.7f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L249
floating point literal has suffix 'f', which is not uppercase [readability-uppercase-literal-suffix]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L310
15 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L316
10 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
Lint / Lint: src/Mod/Sketcher/Gui/ViewProviderSketch.cpp#L322
0x0f0f is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers,readability-magic-numbers]
Pixi / build_with_pixi (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Pixi / build_with_pixi (macos-latest): src/3rdParty/libE57Format/src/SourceDestBufferImpl.cpp#L491
implicit conversion from 'const int64_t' (aka 'const long long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-const-int-float-conversion]
Pixi / build_with_pixi (macos-latest): src/3rdParty/libE57Format/src/SourceDestBufferImpl.cpp#L203
implicit conversion from 'const int32_t' (aka 'const int') to 'float' changes value from 2147483647 to 2147483648 [-Wimplicit-const-int-float-conversion]
Pixi / build_with_pixi (macos-latest): src/3rdParty/libE57Format/src/SourceDestBufferImpl.cpp#L215
implicit conversion from 'const uint32_t' (aka 'const unsigned int') to 'float' changes value from 4294967295 to 4294967296 [-Wimplicit-const-int-float-conversion]
Pixi / build_with_pixi (macos-latest): src/3rdParty/libE57Format/src/SourceDestBufferImpl.cpp#L227
implicit conversion from 'const int64_t' (aka 'const long long') to 'float' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-const-int-float-conversion]
Pixi / build_with_pixi (macos-latest): src/3rdParty/libE57Format/src/SourceDestBufferImpl.cpp#L227
implicit conversion from 'const int64_t' (aka 'const long long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-const-int-float-conversion]
Ubuntu_20-04 / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Ubuntu_20-04 / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Windows / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Windows / Build
Input 'save-always' has been deprecated with message: save-always does not work as intended and will be removed in a future release. A separate `actions/cache/restore` step should be used instead. See https://github.com/actions/cache/tree/main/save#always-save-cache for more details.
Pixi / build_with_pixi (windows-latest)
No files were found with the provided path: D:\a\FreeCAD\FreeCAD/logs/ /var/crash/*FreeCAD*. No artifacts will be uploaded.
Pixi / build_with_pixi (windows-latest)
'=': conversion from 'size_t' to '_Ty', possible loss of data
Pixi / build_with_pixi (windows-latest)
No files were found with the provided path: D:\a\FreeCAD\FreeCAD/report/Pixi-12915915955-windows-latest-report.md. No artifacts will be uploaded.
WrapUp / WrapUp
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Artifacts

Produced during runtime
Name Size
Lint-12915915955-Logs
56.4 KB
Pixi-12915915955-macos-latest-Logs
45.7 KB
Pixi-12915915955-macos-latest-report.md
406 Bytes
Pixi-12915915955-ubuntu-latest-Logs
46 KB
Pixi-12915915955-ubuntu-latest-report.md
595 Bytes
Prepare-12915915955-Logs
3.9 KB
Ubuntu_20-04-12915915955-Logs
187 KB
Windows-12915915955-Logs
1.64 MB