[Gui] Update View and Structure toolbars using conditional defs #1118
Annotations
2 errors and 20 warnings
Codespell
Process completed with exit code 2.
|
Cpplint
Process completed with exit code 2.
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Clazy:
src/Base/Type.h#L119
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Type.h#L150
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Type.h#L155
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Type.h#L160
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Type.h#L165
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Type.h#L170
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
src/Base/Type.h#L175
Pass small and trivially-copyable type by value (const class Base::Type &) [-Wclazy-function-args-by-value]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L971
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L1002
fmt::detail::iterator_buffer has dtor but not copy-ctor, copy-assignment [-Wclazy-rule-of-three]
|
Clazy:
build/_deps/fmt-src/include/fmt/core.h#L2095
Returning a void expression [-Wclazy-returning-void-expression]
|
Clang-tidy:
src/Gui/Workbench.cpp#L252
function 'setupCustomToolbars' has cognitive complexity of 32 (threshold 25) [readability-function-cognitive-complexity]
|
Clang-tidy:
src/Gui/Workbench.cpp#L252
the const qualified parameter 'hGrp' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
|
Clang-tidy:
src/Gui/Workbench.cpp#L328
all parameters should be named in a function [readability-named-parameter]
|
Clang-tidy:
src/Gui/Workbench.cpp#L342
do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,modernize-avoid-c-arrays]
|
Clang-tidy:
src/Gui/Workbench.cpp#L346
do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
|
Clang-tidy:
src/Gui/Workbench.cpp#L573
initializer for base class 'Gui::Workbench' is redundant [readability-redundant-member-init]
|
Clang-tidy:
src/Gui/Workbench.cpp#L890
initializer for base class 'Gui::Workbench' is redundant [readability-redundant-member-init]
|
Clang-tidy:
src/Gui/Workbench.cpp#L941
initializer for base class 'Gui::StdWorkbench' is redundant [readability-redundant-member-init]
|
Clang-tidy:
src/Gui/Workbench.cpp#L1009
initializer for base class 'Gui::StdWorkbench' is redundant [readability-redundant-member-init]
|
Loading