Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php 8.4 #8

Merged
merged 4 commits into from
Jan 19, 2025
Merged

Add php 8.4 #8

merged 4 commits into from
Jan 19, 2025

Conversation

mpysiak
Copy link
Member

@mpysiak mpysiak commented Jan 8, 2025

No description provided.

@mpysiak mpysiak force-pushed the add-php-8.4 branch 2 times, most recently from a6d45c7 to 911085d Compare January 8, 2025 11:38
As of the PHP 8.4 release, the chmod of the /usr/local/bin/docker-php-entrypoint file has been changed to 755.
@piotrkardasz
Copy link
Collaborator

Hello @mpysiak

  1. I have updated the APCu extension version from 5.1.21 to 5.1.24 because previous version does not support PHP 8.4 🤷
  2. I also have updated repository variables to support newer version of xdebug
XDEBUG_VERSION_PHP_8_0 `3.3.1 => 3.4.1`
XDEBUG_VERSION_PHP_8_1 `3.3.1 => 3.4.1`
XDEBUG_VERSION_PHP_8_2 `3.3.1 => 3.4.1`
XDEBUG_VERSION_PHP_8_3 `3.3.1 => 3.4.1`
XDEBUG_VERSION_PHP_8_4 `3.4.1`
  1. For some (probably security) reasons the permissions to PHP entry point '/usr/local/bin/docker-php-entrypoint' has been changed from 775 to 755 in the base PHP Docker images that's why I need to update affected Bazel tests

@piotrkardasz piotrkardasz merged commit b825da3 into Sylius:main Jan 19, 2025
3 checks passed
@mpysiak mpysiak deleted the add-php-8.4 branch January 20, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants