[Maintenance] Bump plugin to Sylius 2.0 #437
Conversation
mpysiak
commented
Nov 18, 2024
mpysiak
commented
| Q | A |
|---|---|
| Branch? | 2.0 |
| Bug fix? | no |
| New feature? | no |
| Related tickets | n/a |
mpysiak
force-pushed
the
SYL-3914-bump-plugin-to-2.0
branch
from
b85699d to
b347b9d
Compare
mpysiak
changed the title
mpysiak
force-pushed
the
SYL-3914-bump-plugin-to-2.0
branch
3 times, most recently
from
f34b9c1 to
fd5d520
Compare
| private RefundFactoryInterface $refundFactory, | ||
| private RemainingTotalProviderInterface $remainingTotalProvider, | ||
| private OrderRepositoryInterface $orderRepository, | ||
| private ObjectManager $refundManager, |
There was a problem hiding this comment.
I think it makes sense to replace every ObjectManager with EntityManagerInterface since odm support is dropped. (There are 12 instances of ObjectManager in the codebase.)
| private ObjectManager $refundManager, | |
| private EntityManagerInterface $refundManager, |
src/templates/order/admin/content/header/title_block/actions/refunds.html.twig
Outdated
Show resolved
Hide resolved
src/templates/order/admin/content/sections/payments/item/name.html.twig
Outdated
Show resolved
Hide resolved
src/templates/order/admin/refund/content/header/title_block/actions.html.twig
Outdated
Show resolved
Hide resolved
src/templates/order/admin/refund/content/header/title_block/actions/refund_all.html.twig
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Do you plan to rename all templates to snake_case? This one still at camelCase.
There was a problem hiding this comment.
I think this file still exists, but now empty. But I'm not sure if GH shows this right.
If true, then this file as well tests/Application/assets/shop/entry.js
| "symfony/messenger": "^5.4.21 || ^6.4" | ||
| "php": "^8.2", | ||
| "knplabs/knp-snappy-bundle": "^1.10", | ||
| "myclabs/php-enum": "^1.8", |
There was a problem hiding this comment.
I would say it's high time to drop pseudo enum support and use sylius/sylius style consts (or php enums)
There was a problem hiding this comment.
We would like to do that. There is another task for that. This will be done in another PR
|
Thanks @diimpp for your code review! However, this PR is still very much a work in progress, and I didn't mark it as a draft :) |
mpysiak
force-pushed
the
SYL-3914-bump-plugin-to-2.0
branch
7 times, most recently
from
f5fe65a to
9dddf97
Compare
@mpysiak You're welcome. Please ping me when it's done. :) Do you plan to refactor how refund items entities are structured or it's more of the maintenance PR? There is this issue from 2020 #193, which I think still actual. Described problem is more about letting people develop based of this plugin, rather then solving immediate bug. tldr: Add "root" entity |
mpysiak
force-pushed
the
SYL-3914-bump-plugin-to-2.0
branch
10 times, most recently
from
eb2fe2d to
51cc2ca
Compare
mpysiak
force-pushed
the
SYL-3914-bump-plugin-to-2.0
branch
from
51cc2ca to
92bd78c
Compare
|
@diimpp This PR is mainly Maintenance - just to bump to Sylius 2.0. I've removed deprecations, add some small refactors. But PR is getting huge, so it will be probably merged (after CR from the team). Comments and fixes will be done in other commits, to make it small and more transparent 🖖 |
| <tr> | ||
| {% hook 'table.header' %} | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| {% hook 'table.body' %} | ||
| </tbody> |
There was a problem hiding this comment.
It could be confusing not to have a table hook, I don't know if it wouldn't be better to add an additional template with it and trigger these two there 🤔
src/templates/order/admin/refund/content/sections/form/table/body/item/refund_button.html.twig
Show resolved
Hide resolved
src/templates/order/admin/refund/content/sections/form/table/shipment.html.twig
Show resolved
Hide resolved
