Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for session secrets in Renku 2.0 #3837

Merged
merged 12 commits into from
Dec 18, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Nov 13, 2024

Closes #3832.

Add support for session secret slots and session secrets in Renku 2.0.

/deploy

@RenkuBot
Copy link
Collaborator

You can access the deployment of this PR at https://ci-renku-3837.dev.renku.ch

Base automatically changed from feat-jupyter-free-sessions to release-0.61.0 November 19, 2024 08:23
@leafty leafty force-pushed the build/session-secrets branch from 35236e9 to 33c5e5a Compare November 19, 2024 08:27
@leafty leafty marked this pull request as ready for review December 17, 2024 13:50
@leafty leafty requested review from a team as code owners December 17, 2024 13:50
Copy link
Member

@rokroskar rokroskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leafty! just a couple of comments

CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated
Session secrets make it possible to connect to protected resources, such as databases or external
compute systems, from a Renku session in a standardized and shareable manner. Collaborating with
secrets is easy too: configure a single session secret slot to ensure that the secret shows up
the same way for everyone, and each person enters their own value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to make it clearer that the secrets themselves are not shared, just the configuration?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tagging @lokijuhy who wrote the release text.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsie, I had the old copy. Now updated with 5685b71.

CHANGELOG.rst Outdated Show resolved Hide resolved
Copy link
Member

@lokijuhy lokijuhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all of @andre-code's changes supposed to be included in the changelog here? I see them mentioned in the UI tagged release.

@olevski olevski self-requested a review December 18, 2024 08:14
@leafty
Copy link
Member Author

leafty commented Dec 18, 2024

Are all of @andre-code's changes supposed to be included in the changelog here? I see them mentioned in the UI tagged release.

Fixed in 5a48991.

@leafty leafty merged commit 5d14ba1 into release-0.62.0 Dec 18, 2024
17 checks passed
@leafty leafty deleted the build/session-secrets branch December 18, 2024 08:48
Panaetius pushed a commit that referenced this pull request Dec 18, 2024
Closes #3832.

Add support for session secret slots and session secrets in Renku 2.0.

---------

Co-authored-by: Tasko Olevski <[email protected]>
Panaetius added a commit that referenced this pull request Dec 19, 2024
* chore: create release 0.62.0

* chore: update redis helm chart to latest revision (#3843)

* feat: remove internal gitlab (#3297)

Co-authored-by: Rok Roškar <[email protected]>

* Update search to release 0.7.0 (#3852)

* fix: point redis helm chart to the oci URI (#3855)

* tests: remove check of project container for anonymous users (#3853)

* feat: add support for session secrets in Renku 2.0 (#3837)

Closes #3832.

Add support for session secret slots and session secrets in Renku 2.0.

---------

Co-authored-by: Tasko Olevski <[email protected]>

* chore: add note about polybox/switchdrive to the top changelog (#3856)

* feat: update user and group pages design (#3857)


Co-authored-by: Flora Thiebaut <[email protected]>

* Update CHANGELOG.rst

* Update CHANGELOG.rst

---------

Co-authored-by: Lionel Sambuc <[email protected]>
Co-authored-by: Tasko Olevski <[email protected]>
Co-authored-by: Rok Roškar <[email protected]>
Co-authored-by: eikek <[email protected]>
Co-authored-by: Andrea Cordoba <[email protected]>
Co-authored-by: Flora Thiebaut <[email protected]>
Co-authored-by: Tasko Olevski <[email protected]>
Co-authored-by: Rok Roškar <[email protected]>
Co-authored-by: Ralf Grubenmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants