Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update selenium-java from 4.18.1 to 4.19.1 #3564

Closed
wants to merge 20 commits into from

Conversation

RenkuBot
Copy link
Collaborator

@RenkuBot RenkuBot commented Mar 30, 2024

About this PR

πŸ“¦ Updates org.seleniumhq.selenium:selenium-java from 4.18.1 to 4.19.1

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.seleniumhq.selenium", artifactId = "selenium-java" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.seleniumhq.selenium", artifactId = "selenium-java" }
}]
labels: test-library-update, early-semver-minor, semver-spec-minor, commit-count:1

/deploy

RenkuBot and others added 18 commits March 6, 2024 09:52
Bumps [azure/setup-helm](https://github.com/azure/setup-helm) from 3 to 4.
- [Release notes](https://github.com/azure/setup-helm/releases)
- [Changelog](https://github.com/Azure/setup-helm/blob/main/CHANGELOG.md)
- [Commits](Azure/setup-helm@v3...v4)

---
updated-dependencies:
- dependency-name: azure/setup-helm
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rok RoΕ‘kar <[email protected]>
The value is not used anymore and we should remove it to
avoid confusion.

Co-authored-by: Rok RoΕ‘kar <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.1.1...v4.1.2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Rok RoΕ‘kar <[email protected]>
* chore: Renku search helm charts (#3481)

* feat: add Solr to the subcharts.

* feat: add message queue Redis to data-services (#3508)

* chore: add gateway config for search endpoint

* chore: add redis values for users sync svc

* chore: add redis access to user sync job
* chore: renku-jena 0.0.25

* chore: graph updated to 2.50.0
The current version shows the configuration at the top level of
the yaml while it should be under the global portion.
Co-authored-by: Rok RoΕ‘kar <[email protected]>
Co-authored-by: Rok RoΕ‘kar <[email protected]>
Co-authored-by: Ralf Grubenmann <[email protected]>
@RenkuBot
Copy link
Collaborator Author

You can access the deployment of this PR at https://ci-renku-3564.dev.renku.ch

@eikek eikek changed the base branch from master to release-0.50.x April 2, 2024 06:24
@eikek eikek force-pushed the update/selenium-java-4.19.1 branch from 808a9c6 to 773925a Compare April 2, 2024 06:24
@eikek eikek temporarily deployed to ci-renku-3564 April 2, 2024 06:24 — with GitHub Actions Inactive
@rokroskar
Copy link
Member

rokroskar commented Apr 2, 2024

@jachro @eikek can we close this for now? I suppose the incompatibility will be fixed eventually, but it's not critical for us to have this update, correct?

@eikek
Copy link
Member

eikek commented Apr 2, 2024

No, not at all critical to me. We can close it or leave it open as a reminder.

@rokroskar
Copy link
Member

ok lets close it then unless we want to invest time in fixing the chromium/selenium incompatibility?

@olevski olevski changed the base branch from release-0.50.x to release-0.51.x April 3, 2024 08:46
@olevski olevski requested review from a team as code owners April 3, 2024 08:46
@jachro
Copy link
Contributor

jachro commented Apr 3, 2024

I was thinking to look into that later today or tomorrow.

@jachro
Copy link
Contributor

jachro commented Apr 3, 2024

I might be wrong but it looks to me that the problem comes from incompatibility between selenium driver and chromium. I tried some suggestions from other people but it didn't work. Yes, let's maybe wait until some new version of chromium-driver is available for python:3.9-slim that we use in the container.

@jachro jachro closed this Apr 3, 2024
@rokroskar rokroskar deleted the update/selenium-java-4.19.1 branch April 3, 2024 13:51
@RenkuBot
Copy link
Collaborator Author

Superseded by #3597.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.