Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support project documentation without CK Editor upgrade #3478

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jan 10, 2025

Separate the project documentation support from the ck-editor upgrade in #3390.

Screenshots

UI changes compared to initial version

Display text if there is no documentation

image

Show edit view in a modal dialog

image image

/deploy

@ciyer ciyer force-pushed the ciyer/project-docu-minimal branch from a79784a to a465c67 Compare January 10, 2025 13:17
@ciyer ciyer temporarily deployed to renku-ci-ui-3478 January 10, 2025 13:17 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3478.dev.renku.ch

@ciyer ciyer temporarily deployed to renku-ci-ui-3478 January 17, 2025 09:49 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/project-docu-minimal branch from 2aa8034 to e5afcce Compare January 17, 2025 10:38
@ciyer ciyer temporarily deployed to renku-ci-ui-3478 January 17, 2025 10:38 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-3478 January 17, 2025 12:27 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-3478 January 17, 2025 12:44 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-3478 January 17, 2025 12:56 — with GitHub Actions Inactive
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small comments below.

Comment on lines 151 to 153
useEffect(() => {
setValue("documentation", project.documentation || "");
}, [project.documentation, setValue]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other forms, we use the reset() function for this:

Suggested change
useEffect(() => {
setValue("documentation", project.documentation || "");
}, [project.documentation, setValue]);
useEffect(() => {
reset({
documentation: project.documentation || "",
});
}, [project.documentation, reset]);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c82a37b

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file necessary? There is already a max height rule on modals from bootstrap.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something about CK editor caused the bounds of the modal to exceed the viewport size when you insert a lot of text. This style makes it behave better.

)}
</div>
) : (
<div className="mb-2"></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c82a37b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants