Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ShapeUp] Renku 2.0 Sessions #3037

Merged
merged 10 commits into from
Mar 25, 2024
Merged

[ShapeUp] Renku 2.0 Sessions #3037

merged 10 commits into from
Mar 25, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Feb 14, 2024 •
edited
Loading

Add initial support for Renku 2.0 sessions.

  • Add new features for sessions in Renku 2.0: session environments and session launchers
  • Add session environment management to admin page
  • Add session launchers to Renku 2.0 projects
  • Can start a session from a session launcher
  • Can open a running session
  • Can perform session actions (pause, delete, modify)
  • Renku 1.0 and Renku 2.0 sessions are not co-mingled: Renku 1.0 sessions continue to appear in the dashboard, etc. while Renku 2.0 sessions will appear only in /v2 pages.

Limitations:

  • Sessions can work with projects with zero repositories.
  • Sessions for projects with at least one repository will only work if the first repository is in GitLab.

See SwissDataScienceCenter/renku#3475.

/deploy renku=build/new-sessions renku-data-services=main renku-notebooks=master

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3037.dev.renku.ch

@leafty leafty force-pushed the build/new-sessions branch from 1d7cde3 to f3392fe Compare February 14, 2024 10:25
@leafty leafty force-pushed the build/new-sessions branch from f3392fe to 76a973d Compare February 14, 2024 10:28
@leafty leafty temporarily deployed to renku-ci-ui-3037 February 14, 2024 10:28 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3037 February 14, 2024 13:01 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3037 February 15, 2024 10:26 — with GitHub Actions Inactive
@leafty leafty force-pushed the build/new-sessions branch from 4a437fd to 90c3146 Compare February 15, 2024 11:58
@leafty leafty temporarily deployed to renku-ci-ui-3037 February 15, 2024 11:58 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3037 February 16, 2024 09:14 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3037 February 26, 2024 08:12 — with GitHub Actions Inactive
@leafty leafty changed the title [ShapeUp] Renku 1.0 Sessions [ShapeUp] Renku 2.0 Sessions Mar 8, 2024
@leafty leafty temporarily deployed to renku-ci-ui-3037 March 8, 2024 10:44 — with GitHub Actions Inactive
leafty added 5 commits March 8, 2024 14:23
@leafty
feat(client): add support for creating sessions in Renku 1.0 (#3021)
eb766ce 
Fixes #3020.

Add first draft API for Renku 1.0 sessions and UI for creating them. It should be noted that the backend service is not implemented at this time.
@leafty
feat(client): add UI to update and delete sessions (#3034)
de3d093 
Fixes #3029.

Add the UI to edit and delete sessions. It should be noted that the backend service is not implemented at this time.
@leafty
feat(client): connect to the sessions v2 backend (#3043)
207277a 
Fixes #3044.
@leafty
feat(client): add support for session environments (Renku 1.0) (#3046)
1c21ec5 
Fixes #3045.

* Add support for session environments
* Refactor sessions API to reflect name change to session launchers
@leafty
feat(client): add default URL to Renku 1.0 session entities (#3055)
66cbfa9
@leafty leafty force-pushed the build/new-sessions branch from ec8cff3 to 66cbfa9 Compare March 8, 2024 13:23
@leafty leafty temporarily deployed to renku-ci-ui-3037 March 8, 2024 13:24 — with GitHub Actions Inactive
@leafty
feat(client): initial support for Renku 2.0 sessions (#3070)
0b72037 
Fixes #3049.

Add initial support for Renku 2.0 sessions.

* Can start a session from a session launcher
* Can open a running session
* Can perform session actions (pause, delete, modify)
* Renku 1.0 and Renku 2.0 sessions are not co-mingled: Renku 1.0 sessions continue to appear in the dashboard, etc. while Renku 2.0 sessions will appear only in `/v2` pages.

Limitations:
* Sessions can work with projects with zero repositories.
* Sessions for projects with at least one repository will only work if the first repository is in GitLab.
@leafty leafty temporarily deployed to renku-ci-ui-3037 March 12, 2024 10:40 — with GitHub Actions Inactive
@leafty
feat(client): support Renku 2.0 sessions with multiple repositories (#…
987fa6d 
…3069)

Update the Renku 2.0 sessions UI:
* Check if each repository in a project is accessible, i.e. it is found in GitLab and can be accessed by the user
* Request mounting each supported repository when starting sessions
@leafty leafty temporarily deployed to renku-ci-ui-3037 March 19, 2024 09:28 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3037 March 19, 2024 09:39 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review March 19, 2024 09:49
@leafty leafty requested a review from a team as a code owner March 19, 2024 09:49
@leafty leafty temporarily deployed to renku-ci-ui-3037 March 19, 2024 09:50 — with GitHub Actions Inactive
andre-code
andre-code reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@andre-code andre-code left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see this feature in action; overall, well done! It functions as expected. At this stage, I've left some suggestions to make it easier to reuse the code generated here for future features, such as when we're working on the project page.

client/src/features/sessionsV2/ActiveSessionButton.tsx Outdated Show resolved Hide resolved
client/src/features/sessionsV2/ActiveSessionButton.tsx Show resolved Hide resolved
client/src/features/sessionsV2/ActiveSessionButton.tsx Show resolved Hide resolved
client/src/features/sessionsV2/PauseOrDeleteSessionModal.tsx Outdated Show resolved Hide resolved
andre-code
andre-code approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@leafty leafty merged commit fa2a39d into main Mar 25, 2024
21 of 23 checks passed
@leafty leafty deleted the build/new-sessions branch March 25, 2024 09:12
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andre-code andre-code andre-code approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leafty @RenkuBot @andre-code