feat: a simple service exposing Search API #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikek
approved these changes
Jan 30, 2024
|
|
||
| trait Implicits: | ||
|
|
||
| implicit def entityDecoder[F[_]: Async, A: AvroJsonDecoder]: EntityDecoder[F, A] = |
There was a problem hiding this comment.
We can now use given:) (I might forgot to change that myself when I used code from somewhere else:))
There was a problem hiding this comment.
Yes, I used metrics collector as a template ;)
| import org.http4s.dsl.Http4sDsl | ||
| import scribe.Scribe | ||
|
|
||
| private class SearchApiImpl[F[_]: Async: Scribe](solrClient: SearchSolrClient[F]) |
There was a problem hiding this comment.
I know we have it like this in graph passing in the logger from outside. I'm not sure why that is good? Why wouldn't we want to have different loggers per class?
| AvroJsonEncoder.encodeList[ApiProject](ApiProject.SCHEMA$) | ||
|
|
||
| private def toAvroResponse(entities: List[ApiProject]): Response[F] = | ||
| Response[F](Ok) |
There was a problem hiding this comment.
with Http4sDsl in scope, I think writing Ok(entities) should work as well. A separate method might then not be needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings some initial implementation of the Search API service.