Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor email and provision #58

Merged
merged 13 commits into from
Mar 15, 2024
Merged

Conversation

eikek
Copy link
Member

@eikek eikek commented Mar 15, 2024

  • refactors message handler code: moved parts into their own building blocks. MessageHandlers is the entry point for defining all message handlers that can be composed from various utilities based on fs2.Stream|Pipe
  • Remove the default events queue name. Now starting up fails, if queue names are not correctly configured
  • Remove email from the user document so it's not stored in solr
  • When updating documents, score must be unset. Could be better modelled, given this big pr already it's only reset now
  • updates dev setup and adds more scripts for playing around
  • fixes issue where searching doesn't return results for certain terms due to wrong casing

@eikek eikek force-pushed the refactor-email-and-provision branch from 6cc75c6 to 2fc7cea Compare March 15, 2024 07:12
@eikek eikek marked this pull request as ready for review March 15, 2024 07:47
Copy link
Contributor

@jachro jachro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@eikek eikek merged commit a317f3e into development Mar 15, 2024
2 checks passed
@eikek eikek deleted the refactor-email-and-provision branch March 15, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants