New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Create correct solr query in case only `sort` terms are specfified #51

Merged

eikek merged 3 commits into development from fix/single-sort-no-results

Mar 8, 2024

Member

eikek commented Mar 8, 2024 •

edited

Loading

fixes the solr query generated when the user only specifies sort terms
moves def generateOne extension methods to commons module
adds a LoggingConfigure trait for tests to avoid logging too much stuff. If mixed in, the verbosity is set to 0 meaning only ERROR messages will be printed. It is not applied to all specs

eikek and others added 3 commits

March 7, 2024 18:19


          WIP: Fix empty query when sort is present

4cd22f7


          Fix solr query when only sort terms are specified

9d53633


          Move definition of generateOne into a single trait

2addbff

It started to be redefined in various places.

eikek marked this pull request as ready for review

March 8, 2024 10:14

jachro approved these changes

View reviewed changes

eikek merged commit ad8c1cc into development

2 checks passed

eikek deleted the fix/single-sort-no-results branch

March 8, 2024 13:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet