feat: Enable paging for search endpoints #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just moving things into separate files for better discoverability/readability
jachro
reviewed
Feb 23, 2024
|
|
||
| lazy val router: HttpApp[F] = | ||
| Router[F]( | ||
| s"/$businessRoot" -> businessRoutes, | ||
| "/" -> operationsRoutes | ||
| "/search" -> (OpenApiRoute(businessEndpoints) <+> search.routes), |
There was a problem hiding this comment.
I was wondering if it wouldn't be good to keep the /search segment somewhere so it can be shared between this class and the SearchRoutes (the definition of server for the OpenAPI spec).
There was a problem hiding this comment.
Ah, I removed it because it wasn't used anywhere else - but I now saw the other occurrence in OpenApiRoute. Thanks, will bring it back!
jachro
reviewed
Feb 23, 2024
| val perPage = | ||
| queryParam[Int]("per_page") | ||
| .description("How many items to return for one page") | ||
| .validate(Validator.min(1)) |
There was a problem hiding this comment.
Just so we won't forget, maybe we could add max validator as we are working on this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accepts optional request parameters
per_pageandpageand return paging information with response headers.