Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove license header from all source files #255

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Remove license header from all source files #255

merged 3 commits into from
Jan 8, 2025

Conversation

eikek
Copy link
Member

@eikek eikek commented Jan 7, 2025

No description provided.

@eikek eikek requested a review from a team as a code owner January 7, 2025 10:31
@eikek eikek enabled auto-merge January 7, 2025 10:31
@eikek eikek added the chore Maintenance work label Jan 7, 2025
@Panaetius
Copy link
Member

the year is not needed in each file.

No year/copyright in files: https://apache.org/legal/src-headers.html#headers
Copyright and year should be in NOTICE file: https://www.apache.org/legal/src-headers.html#notice

@eikek
Copy link
Member Author

eikek commented Jan 8, 2025

I think these guidelines are for software developed for the ASF. The license itself can be applied outsied the ASF. There is a little appendix for that: https://www.apache.org/licenses/LICENSE-2.0.html#apply -- and the example there includes the year 🤷🏼

I don't think a license header is necessary to apply the license (see https://www.apache.org/legal/apply-license.html#copy-per-file). It is enough to state noticeably that the project is distributed under this license. Tbh, I personally don't like the boileplate of repeating this license text in every file. I would be in favor to remove this entirely - or do we have this requirement at the sdsc?

@Panaetius
Copy link
Member

just remove it entirely. we already did so in data services.

@eikek eikek closed this Jan 8, 2025
auto-merge was automatically disabled January 8, 2025 11:21

Pull request was closed

@eikek eikek reopened this Jan 8, 2025
@eikek eikek changed the title Update headers in source files to year 2025 Remove license header from all source files Jan 8, 2025
@eikek eikek enabled auto-merge January 8, 2025 11:27
@eikek eikek merged commit 8b3ba2b into main Jan 8, 2025
3 checks passed
@eikek eikek deleted the update-headers branch January 8, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants