Refactor querying for renku enitities #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikek
force-pushed
the
search-query-refactor
branch
from
b48c866 to
1201f46
Compare
eikek
force-pushed
the
search-query-refactor
branch
from
1201f46 to
a131822
Compare
- Move additional query constraints into single place (SearchSolrClient) - Have a separate class for converting a user query into the final solr query (to be easier to test and have a dedicated place for this important piece) - Add more tests for query amendments
eikek
force-pushed
the
search-query-refactor
branch
from
a131822 to
d9f9ad1
Compare
Panaetius
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move additional query constraints into single place (SearchSolrClient)
Have a separate class for converting a user query into the final solr query (to be easier to test and have a dedicated place for this important piece)
Add more tests for query amendments