Restrict search results to valid entities #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will select only entities, where a `namespace` property exists. Additionally, it selects only projects that have an existing `createBy` property. This doesn't filter out results, where a subquery would return no results.
This adds the ability to use a cursor for paginated results.
- Move additional query constraints into single place (SearchSolrClient) - Have a separate class for converting a user query into the final solr query (to be easier to test and have a dedicated place for this important piece) - Add more tests for query amendments
eikek
force-pushed
the
query-namespace
branch
from
381cff3 to
311a0ac
Compare
eikek
force-pushed
the
query-namespace
branch
from
311a0ac to
e232e21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes results from search as has been discussed:
createdByproperty (this should always be there, such a property missing indicates a processing error)namespacecan not be found, resolving it yields no results