Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): set job timeouts correctly #3651

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

Panaetius
Copy link
Member

adds timeouts to rq jobs to cleanup metrics dashboard.
ttl=how long a job stays enqueued before failing
failure_ttl=how long a failed job is kept around

Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay Ralf.

@Panaetius Panaetius merged commit db0f8cf into develop Nov 8, 2023
17 of 20 checks passed
@Panaetius Panaetius deleted the fix-svc-job-timeouts branch November 8, 2023 15:34
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6797170421

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.09%) to 82.837%

Files with Coverage Reduction New Missed Lines %
renku/domain_model/dataset.py 1 93.07%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 28.57%
renku/command/rollback.py 2 78.7%
renku/core/dataset/providers/zenodo.py 22 68.13%
Totals Coverage Status
Change from base Build 6558831811: -0.09%
Covered Lines: 25450
Relevant Lines: 30723

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants