Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svc): rename git_url to template_git_url and return git_url on all endpoints #3646

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Oct 20, 2023

closes #3564

@coveralls
Copy link
Collaborator

coveralls commented Oct 20, 2023

Pull Request Test Coverage Report for Build 6850695882

  • 109 of 137 (79.56%) changed or added relevant lines in 12 files are covered.
  • 8 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+3.2%) to 86.024%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/ui/service/serializers/templates.py 30 32 93.75%
renku/ui/service/views/v1/templates.py 19 23 82.61%
renku/ui/service/serializers/v1/templates.py 29 51 56.86%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/dataset.py 1 85.19%
renku/core/dataset/providers/dataverse.py 1 88.86%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/core/migration/models/v3.py 1 97.24%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 28.57%
renku/command/rollback.py 2 78.7%
Totals Coverage Status
Change from base Build 6823291196: 3.2%
Covered Lines: 26522
Relevant Lines: 30831

💛 - Coveralls

@Panaetius Panaetius force-pushed the feat/3564-svc-git-url branch 3 times, most recently from 9b83a53 to 1253e66 Compare October 20, 2023 15:09
@Panaetius Panaetius marked this pull request as ready for review October 20, 2023 15:40
@Panaetius Panaetius force-pushed the feat/3564-svc-git-url branch from 1253e66 to d5ed339 Compare October 20, 2023 15:40
@Panaetius Panaetius requested a review from a team as a code owner October 20, 2023 15:40
@Panaetius
Copy link
Member Author

This should be ready. Feel free to merge. Need to coordinate with UI when it is merged

renku/ui/service/serializers/datasets.py Show resolved Hide resolved
renku/ui/service/serializers/templates.py Outdated Show resolved Hide resolved
renku/ui/service/serializers/templates.py Show resolved Hide resolved
@Panaetius Panaetius force-pushed the feat/3564-svc-git-url branch 4 times, most recently from 80f315f to 4891f27 Compare November 10, 2023 15:38
@Panaetius Panaetius force-pushed the feat/3564-svc-git-url branch from 4891f27 to 89cbce9 Compare November 13, 2023 13:31
@Panaetius Panaetius requested a review from olevski November 13, 2023 13:32
@Panaetius Panaetius merged commit 314786e into develop Nov 15, 2023
25 of 28 checks passed
@Panaetius Panaetius deleted the feat/3564-svc-git-url branch November 15, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Return git_url in core-service responses
3 participants