Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): add ssh_supported flag to template and migrations_check #3294

Merged
merged 5 commits into from
Feb 14, 2023
Merged

feat(core): add ssh_supported flag to template and migrations_check #3294

merged 5 commits into from
Feb 14, 2023

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Jan 24, 2023 •
edited
Loading

closes #3293

@Panaetius Panaetius temporarily deployed to renku-ci-rp-3294 January 24, 2023 15:51 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-rp-3294.dev.renku.ch

@Panaetius Panaetius force-pushed the topic/3239-ssh-migrations-check branch from 1dfad3f to 3c14e93 Compare January 25, 2023 08:29
@Panaetius Panaetius temporarily deployed to renku-ci-rp-3294 January 25, 2023 10:34 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi mentioned this pull request Jan 25, 2023
Closed
@Panaetius Panaetius force-pushed the topic/3239-ssh-migrations-check branch from e816d08 to 8c85367 Compare February 6, 2023 12:27
@Panaetius Panaetius temporarily deployed to renku-ci-rp-3294 February 6, 2023 12:28 — with GitHub Actions Inactive
@Panaetius Panaetius marked this pull request as ready for review February 9, 2023 09:56
@Panaetius Panaetius requested a review from a team as a code owner February 9, 2023 09:56
@Panaetius Panaetius marked this pull request as draft February 9, 2023 09:57
@Panaetius Panaetius force-pushed the topic/3239-ssh-migrations-check branch from 8c85367 to 835ff84 Compare February 10, 2023 07:43
@Panaetius Panaetius temporarily deployed to renku-ci-rp-3294 February 10, 2023 07:43 — with GitHub Actions Inactive
@Panaetius Panaetius force-pushed the topic/3239-ssh-migrations-check branch from 835ff84 to f0d83be Compare February 10, 2023 11:02
@Panaetius Panaetius deployed to renku-ci-rp-3294 February 10, 2023 11:02 — with GitHub Actions Active
@Panaetius Panaetius marked this pull request as ready for review February 13, 2023 08:31
mohammad-alisafaee
mohammad-alisafaee reviewed Feb 13, 2023
View reviewed changes
Copy link
Contributor

@mohammad-alisafaee mohammad-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralf! Please see my comments.

renku/ui/cli/config.py Show resolved Hide resolved
renku/ui/cli/config.py Show resolved Hide resolved
@Panaetius Panaetius merged commit 4af6981 into feature/ssh-into-sessions Feb 14, 2023
@Panaetius Panaetius deleted the topic/3239-ssh-migrations-check branch February 14, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammad-alisafaee mohammad-alisafaee mohammad-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Panaetius @RenkuBot @mohammad-alisafaee