Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user preferences service #74

Merged
merged 46 commits into from
Nov 10, 2023

Conversation

leafty
Copy link
Member

@leafty leafty commented Oct 31, 2023

Fixes #64.

Note: merging into a feature branch.

@coveralls
Copy link

coveralls commented Oct 31, 2023

Pull Request Test Coverage Report for Build 6720551860

  • 155 of 214 (72.43%) changed or added relevant lines in 14 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.2%) to 86.183%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bases/renku_data_services/data_api/main.py 1 2 50.0%
components/renku_data_services/user_preferences/models.py 12 13 92.31%
components/renku_data_services/user_preferences_migrations/versions/b1616cce1545_add_user_preferences.py 11 12 91.67%
components/renku_data_services/user_preferences/orm.py 21 23 91.3%
components/renku_data_services/user_preferences/blueprints.py 28 35 80.0%
components/renku_data_services/user_preferences/db.py 23 70 32.86%
Files with Coverage Reduction New Missed Lines %
bases/renku_data_services/data_api/main.py 1 62.22%
components/renku_data_services/crc/db.py 2 85.9%
Totals Coverage Status
Change from base Build 6718704699: -1.2%
Covered Lines: 2626
Relevant Lines: 3047

💛 - Coveralls

@leafty leafty force-pushed the leafty/add-user-preferences branch from 0d55f13 to 47c6602 Compare November 1, 2023 12:25
@leafty leafty changed the base branch from main to feat-add-user-preferences November 2, 2023 08:14
@leafty leafty marked this pull request as ready for review November 6, 2023 13:14
@leafty leafty requested a review from a team as a code owner November 6, 2023 13:14
@leafty leafty requested a review from olevski November 6, 2023 13:14
@olevski
Copy link
Member

olevski commented Nov 6, 2023

Is this ready for review @leafty?

@leafty
Copy link
Member Author

leafty commented Nov 6, 2023

Is this ready for review @leafty?

Yes it is 😄

@leafty leafty requested a review from olevski November 9, 2023 10:27
@leafty leafty merged commit f94f173 into feat-add-user-preferences Nov 10, 2023
7 checks passed
@leafty leafty deleted the leafty/add-user-preferences branch November 10, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a backend and API to store and retrieve user preferences
5 participants