Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add model classes for renku storing entities in solr #624

Merged
merged 19 commits into from
Feb 6, 2025
Merged

feat: Add model classes for renku storing entities in solr #624

merged 19 commits into from
Feb 6, 2025

Conversation

eikek
Copy link
Member

@eikek eikek commented Jan 31, 2025 •
edited
Loading

/deploy

@eikek eikek force-pushed the eikek/solr-models branch 5 times, most recently from fde93af to 6cebeed Compare January 31, 2025 15:49
@eikek eikek marked this pull request as ready for review February 4, 2025 11:08
@eikek eikek requested a review from a team as a code owner February 4, 2025 11:08
@eikek eikek temporarily deployed to renku-ci-ds-624 February 4, 2025 11:23 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 4, 2025

You can access the deployment of this PR at https://renku-ci-ds-624.dev.renku.ch

@eikek eikek force-pushed the feature/search-migration branch from 99ff4e9 to 450fbbb Compare February 4, 2025 12:09
@eikek eikek force-pushed the eikek/solr-models branch from 74ff57b to 5dda4dd Compare February 4, 2025 12:09
@eikek eikek temporarily deployed to renku-ci-ds-624 February 4, 2025 12:10 — with GitHub Actions Inactive
@eikek eikek requested a review from olevski February 4, 2025 16:30
olevski
olevski requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@olevski olevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eikek this is great! I was really picky and feel free to ignore anything that is marked as nitpick.

I was thinking about the snake case / camel case stuff. And I would like to clean it up before we fully merge this. So if you want adress it here. If it is easier just resolve/ignore the comments and we will do camelcase cleanup once at the end before we merge this in main.

.devcontainer/solr/install.sh Show resolved Hide resolved
components/renku_data_services/solr/entity_documents.py Outdated Show resolved Hide resolved
components/renku_data_services/solr/entity_documents.py Show resolved Hide resolved
components/renku_data_services/solr/entity_documents.py Show resolved Hide resolved
components/renku_data_services/solr/entity_schema.py Show resolved Hide resolved
components/renku_data_services/solr/solr_client.py Outdated Show resolved Hide resolved
components/renku_data_services/solr/solr_migrate.py Outdated Show resolved Hide resolved
test/components/renku_data_services/solr/conftest.py Outdated Show resolved Hide resolved
components/renku_data_services/solr/solr_migrate.py Outdated Show resolved Hide resolved
components/renku_data_services/solr/solr_migrate.py Show resolved Hide resolved
@eikek eikek temporarily deployed to renku-ci-ds-624 February 5, 2025 09:26 — with GitHub Actions Inactive
@eikek eikek temporarily deployed to renku-ci-ds-624 February 5, 2025 12:54 — with GitHub Actions Inactive
@eikek eikek requested a review from olevski February 5, 2025 13:12
@eikek eikek temporarily deployed to renku-ci-ds-624 February 5, 2025 13:12 — with GitHub Actions Inactive
@eikek eikek force-pushed the eikek/solr-models branch from 65bec85 to ec93d70 Compare February 5, 2025 13:33
@eikek eikek force-pushed the eikek/solr-models branch from d4d0a28 to f281265 Compare February 5, 2025 13:42
@eikek eikek temporarily deployed to renku-ci-ds-624 February 5, 2025 16:01 — with GitHub Actions Inactive
@eikek eikek merged commit 2dcf0bf into feature/search-migration Feb 6, 2025
13 of 17 checks passed
@eikek eikek deleted the eikek/solr-models branch February 6, 2025 09:56
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 6, 2025

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevski olevski olevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eikek @RenkuBot @olevski