Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow environments to be archived #602

Merged
merged 3 commits into from
Jan 15, 2025
Merged

feat: allow environments to be archived #602

merged 3 commits into from
Jan 15, 2025

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Jan 10, 2025 •
edited
Loading

closes #550

/deploy

@Panaetius Panaetius force-pushed the archive-envs branch 3 times, most recently from 5e4efb2 to 58283c9 Compare January 10, 2025 09:11
@coveralls
Copy link

coveralls commented Jan 10, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12784183109

Details

  • 35 of 35 (100.0%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.03%) to 86.87%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/crc/blueprints.py 1 93.06%
components/renku_data_services/crc/db.py 1 85.46%
components/renku_data_services/crc/models.py 1 84.71%
Totals Coverage Status
Change from base Build 12770429147: 0.03%
Covered Lines: 15231
Relevant Lines: 17533
💛 - Coveralls

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-602.dev.renku.ch

@Panaetius Panaetius marked this pull request as ready for review January 10, 2025 14:46
@Panaetius Panaetius requested a review from a team as a code owner January 10, 2025 14:47
leafty
leafty reviewed Jan 13, 2025
View reviewed changes
test/bases/renku_data_services/data_api/test_sessions.py
assert res.json is not None
assert res.json.get("is_archived")

# Test that you can't create a launcher with an archived environment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: how does this interact with copying a project?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still testing this a bit in the deployment to see how it interacts with other things and make sure it doesn't break anything

leafty
leafty previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. 👏

@Panaetius Panaetius requested a review from leafty January 15, 2025 08:38
@Panaetius Panaetius merged commit ab185c1 into main Jan 15, 2025
17 of 18 checks passed
@Panaetius Panaetius deleted the archive-envs branch January 15, 2025 10:13
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leafty leafty leafty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow (soft-)deleting gobal environments
4 participants
@Panaetius @coveralls @RenkuBot @leafty